Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): add api to migrate card from basilisk to rust #2898

Closed
wants to merge 2 commits into from
Closed

feat(router): add api to migrate card from basilisk to rust #2898

wants to merge 2 commits into from

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pr is to add api to migrate card from basilisk to rust.
#2853

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-11-10 at 3 17 11 PM Screenshot 2023-11-10 at 3 16 37 PM Screenshot 2023-11-10 at 3 16 47 PM Screenshot 2023-11-10 at 3 16 13 PM image Screenshot 2023-11-10 at 3 19 30 PM
  1. Create a two instance of rust locker and configure it as its shown in the first screenshot above.
  2. Make a Payment Method Create call via hyperswitch
  3. Once the card is added, make a post request by passing the merchant_id in the below curl
    In sandbox hit the below endpoint to test this
curl --location --request POST 'http://localhost:8080/locker_migration/merchant_1699604009' \
--header 'api-key: test_admin' \
--header 'Cookie: JSESSIONID.130f0e8f=node01ix1y16yw8z3v1m3nwkr4qbiwb6.node0'

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC @github-actions
feat(router): add api to migrate card from basilisk to rust (#2853)
e760a16 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ShankarSinghC ShankarSinghC requested review from a team as code owners November 17, 2023 10:44
@ShankarSinghC ShankarSinghC changed the base branch from main to hotfix-1.77.0 November 17, 2023 10:47
@ShankarSinghC ShankarSinghC self-assigned this Nov 17, 2023
@ShankarSinghC ShankarSinghC added A-core Area: Core flows C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Nov 17, 2023
SamraatBansal
SamraatBansal approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a cherry-pick from main, approving without review

@ShankarSinghC
Copy link
Contributor Author

Closed this pr as it is already on sandbox and no more required as hotfix

@SanchithHegde SanchithHegde deleted the hotfix/rust-locker-mg branch November 27, 2023 11:51
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShankarSinghC @NishantJoshi00 @SamraatBansal @SanchithHegde